Enhance Python Timestamp to be precision-variable up to nanos, and map it to Timestamp logical type - #39537
Merged
ahmedabu98 merged 6 commits intoJul 30, 2026
Conversation
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
ahmedabu98
requested review from
claudevdm and
tvalentyn
and removed request for
tvalentyn
July 28, 2026 22:38
3 tasks
tvalentyn
reviewed
Jul 29, 2026
Contributor
|
overall LGTM, thanks! |
added 2 commits
July 29, 2026 11:00
…on_timestamp_logicaltype
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuing the work to establish a parameterized Timestamp logical type see design doc (Python Nanosecond Support).
Makes the Java
Timestamplogical type (beam:logical_type:timestamp:v1) portable and maps it to Python'sTimestamp, which now supports variable subsecond precision (0–9 digits).Precision defaults to micros to maintain backwards compatibility, and
Timestamptypehints still map tomicros_instantto maintain update compatibility.Operations that would silently drop sub-microsecond detail (e.g.
micros,to_utc_datetime) will throw unlessallow_lossy_conversion=True. Newstandard_coders.yamlcases pin the wire format cross-SDK.Addresses the Timestamp part of #19922
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.